KellenSunderland commented on issue #15751: Fix the bug of 
`MXEnginePushAsyncND` and `MXEnginePushSyncND`
URL: https://github.com/apache/incubator-mxnet/pull/15751#issuecomment-519198622
 
 
   LGTM.  After considering the API a little I think I wouldn't' consider this 
a breaking change.  Consumers of this package would have gotten errors when 
trying to pass lists of NDArrays to the function.  It's clear that this was the 
intent of the API.  Instead I'd consider this a patch/bugfix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to