apeforest commented on a change in pull request #14779: Fully connected, higher
order grad
URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r311756950
##########
File path: src/operator/nn/fully_connected.cc
##########
@@ -210,11 +222,11 @@ inline static bool FCStorageType(const nnvm::NodeAttrs&
attrs,
return dispatched;
}
-inline static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
- const int dev_mask,
- DispatchMode* dispatch_mode,
- std::vector<int> *in_attrs,
- std::vector<int> *out_attrs) {
+static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
Review comment:
Please add reference. According to this article, the compiler can
automatically detect whether inline is needed.
https://www.geeksforgeeks.org/inline-functions-cpp/
Moreover, if this does not affect the feature you are developing in this PR,
please not change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
