access2rohit commented on a change in pull request #15593: Large Index Support
for Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312252305
##########
File path: python/mxnet/runtime.py
##########
@@ -69,12 +69,18 @@ def feature_list():
features = [lib_features_c_array[i] for i in
range(lib_features_size.value)]
return features
+
class Features(collections.OrderedDict):
"""
OrderedDict of name to Feature
"""
+ feature_dict = None
Review comment:
What is the concern here ? I don't see the harm of keeing it here. I will
change it to singleton but caching results in individual files seems a
makeshift approach. I would still prefer to keep it here for now till singleton
is implemented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
