marcoabreu commented on a change in pull request #15706: [mkldnn-v1.0] Initiate
the transition to MKL-DNN v1.0
URL: https://github.com/apache/incubator-mxnet/pull/15706#discussion_r312709214
##########
File path: CMakeLists.txt
##########
@@ -247,26 +246,23 @@ if(ENABLE_TESTCOVERAGE)
endif()
if(USE_MKLDNN)
- include(cmake/DownloadMKLML.cmake)
# CPU architecture (e.g., C5) can't run on another architecture (e.g., g3).
- if(NOT MSVC)
- set(ARCH_OPT_FLAGS "-mtune=generic")
- else()
+ if(MSVC)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /EHsc")
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /EHsc /Gy")
endif()
- set(WITH_TEST OFF CACHE INTERNAL "" FORCE)
- set(WITH_EXAMPLE OFF CACHE INTERNAL "" FORCE)
- set(ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
+ set(MKLDNN_BUILD_TESTS OFF CACHE INTERNAL "" FORCE)
+ set(MKLDNN_BUILD_EXAMPLES OFF CACHE INTERNAL "" FORCE)
+ set(MKLDNN_ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
+ set(MKLDNN_USE_MKL NONE CACHE INTERNAL "" FORCE)
+ set(MKLDNN_ENABLE_JIT_PROFILING OFF CACHE INTERNAL "" FORCE)
add_subdirectory(3rdparty/mkldnn)
include_directories(3rdparty/mkldnn/include)
include_directories(${PROJECT_BINARY_DIR}/3rdparty/mkldnn/include)
- add_definitions(-DUSE_MKL=1)
- add_definitions(-DCUB_MKL=1)
- add_definitions(-DMXNET_USE_MKLDNN=1)
+ add_definitions(-DMXNET_USE_MKLDNN=100)
Review comment:
It seems a bit unintuitive it you're asking me. Especially because the term
"USE" sounds like a Boolean flag. But what you're actually looking for here is
a version check, right?
Do you have a timeline until everything has been migrated and what's the
plan here exactly? It seems like his PR leaves the master branch in a kinda
unusable state. So may I propose to instead have a separate branch to which you
make all the changes and then merge that to master once everything has been
migrated to 1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
