xidulu opened a new pull request #15857: [Numpy] Added operator logaddexp; 
added support for zero-size tensor in BinaryBroadcastBackwardUseIn 
URL: https://github.com/apache/incubator-mxnet/pull/15857
 
 
   ## Description ##
   - Added 
[np.logaddexp](https://docs.scipy.org/doc/numpy/reference/generated/numpy.logaddexp.html)
 and its docs for future rendering. Scalar calculation is supported.
   
   - Fixed zero-size tensor error in BinaryBroadcastBackwardUseIn (GPU version).
   
   ## Checklist ##
   ### Essentials ###
   
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Added 
[np.logaddexp](https://docs.scipy.org/doc/numpy/reference/generated/numpy.logaddexp.html)
 and its docs for future rendering. Scalar calculation is supported.
   - Fixed zero-size tensor error in BinaryBroadcastBackwardUseIn (GPU version).
   
   
   
   ## Comments ##
   - The previous error case description: when one operand is non-zero-size 
(eg. shape of (1, 3)) and the other is zero-size (eg. shape of (2, 0, 3)), the 
backward calculation on GPU will raise a floating point error.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to