apeforest commented on a change in pull request #15808: Add option to choose between OMP implementations URL: https://github.com/apache/incubator-mxnet/pull/15808#discussion_r313211314
########## File path: CMakeLists.txt ########## @@ -24,6 +24,7 @@ mxnet_option(USE_OLDCMAKECUDA "Build with old cmake cuda" OFF) mxnet_option(USE_NCCL "Use NVidia NCCL with CUDA" OFF) mxnet_option(USE_OPENCV "Build with OpenCV support" ON) mxnet_option(USE_OPENMP "Build with Openmp support" ON) +mxnet_option(USE_OPENMP_BUNDLED_LLVM "Build with bundled llvm openmp from 3rdparty" OFF) Review comment: Is this documented somewhere? Can we set mxnet_option(USE_OPENMP 3RD_PARTY | BUILT_IN)? I am not an expert in CMake so I can not really decide whether this is the most professional way. LGTM for now. But it's better to have someone from CI team to merge this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
