kshitij12345 commented on a change in pull request #15865: [fix] Support nullop in `transpose` URL: https://github.com/apache/incubator-mxnet/pull/15865#discussion_r313246996
########## File path: src/operator/tensor/matrix_op-inl.h ########## @@ -324,6 +324,9 @@ void Transpose(const nnvm::NodeAttrs& attrs, const std::vector<TBlob>& inputs, const std::vector<OpReqType>& req, const std::vector<TBlob>& outputs) { + if (req[0] == kNullOp) { + return; + } const TransposeParam& param = nnvm::get<TransposeParam>(attrs.parsed); CHECK_EQ(req[0], kWriteTo) << "Transpose does not support inplace"; Review comment: Agreed. Will fix it. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services