kshitij12345 commented on issue #15904: Refactor test_random.test_shuffle to improve the timings. URL: https://github.com/apache/incubator-mxnet/pull/15904#issuecomment-521524477 The function : https://github.com/apache/incubator-mxnet/blob/40593c6f6c20baed98a914d14987db5438c0a5a5/tests/python/unittest/test_random.py#L894-L903 doesn't make much sense on https://github.com/apache/incubator-mxnet/blob/40593c6f6c20baed98a914d14987db5438c0a5a5/tests/python/unittest/test_random.py#L967 which is where almost 90% of the time is spent. Is this check necessary for this case? Just removing the check for this particular case will bring time down drastically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
