haojin2 commented on a change in pull request #15905: [Numpy] Basic indexing in
symbolic interface
URL: https://github.com/apache/incubator-mxnet/pull/15905#discussion_r314582455
##########
File path: python/mxnet/symbol/numpy/_symbol.py
##########
@@ -39,25 +46,90 @@ def _num_outputs(sym):
@set_module('mxnet.symbol.numpy')
class _Symbol(Symbol):
- def __getitem__(self, key):
- num_outputs = _num_outputs(self)
- if num_outputs == 1:
- raise NotImplementedError
- if not isinstance(key, int):
+ def __init__(self, handle):
+ super(_Symbol, self).__init__(handle)
+ self._output_is_list = False
+
+ def __getitem__(self, key): # pylint: disable =
too-many-return-statements, inconsistent-return-statements
+ num_outputs = len(self)
+ # print("Num of outputs is ", num_outputs)
Review comment:
Get rid of dead code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
