# [GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15753: Numpy add numpy linalg norm and numpy min

haojin2 commented on a change in pull request #15753: Numpy add numpy linalg
norm and numpy min
URL: https://github.com/apache/incubator-mxnet/pull/15753#discussion_r314588267



##########
File path: python/mxnet/ndarray/numpy/linalg.py
##########
@@ -19,50 +19,184 @@

from __future__ import absolute_import
from . import _op as _mx_nd_np
+from . import _internal as _npi
+

__all__ = ['norm']

+# pylint: disable=line-too-long, too-many-return-statements,
too-many-branches, no-member, consider-using-in, no-else-return
def norm(x, ord=None, axis=None, keepdims=False):
-    r"""Matrix or vector norm.
-
-    This function can only support Frobenius norm for now.
-    The Frobenius norm is given by [1]_:
-
-        :math:||A||_F = [\sum_{i,j} abs(a_{i,j})^2]^{1/2}
+    r"""Matrix or vector norm..
+    This function is able to return one of eight different matrix norms,
+    or one of an infinite number of vector norms (described below), depending
+    on the value of the ord parameter.

Parameters
----------
x : ndarray
-        Input array.
-    ord : {'fro'}, optional
-        Order of the norm.
+        Input array.  If axis is None, x must be 1-D or 2-D.
+    ord : {non-zero int, inf, -inf, 'fro', 'nuc'}, optional

Review comment:
if something ('nuc') is not supported, firstly do not list it as an option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.