larroy commented on a change in pull request #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#discussion_r314592384
 
 

 ##########
 File path: include/mxnet/executor.h
 ##########
 @@ -28,6 +28,8 @@
 
 #include <dmlc/base.h>
 #include <vector>
+#include <unordered_map>
 
 Review comment:
   In the file that is changed, I suggest you dive deeper while reviewing your 
code, you stay on the surface and this kind of review is not very useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to