apeforest commented on issue #14940: Fix warnings URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-521896113 It seems moving the inlining functions to a .cc file is not related to fixing warnings (or please correct me if it does). Please move it to a seperate PR if that refactoring is indeed necessary. In fact, I also read this from: https://www.geeksforgeeks.org/inline-functions-cpp/ It seems the compiler will optimize unnecessary inline functions? ``` Remember, inlining is only a request to the compiler, not a command. Compiler can ignore the request for inlining. Compiler may not perform inlining in such circumstances like: 1) If a function contains a loop. (for, while, do-while) 2) If a function contains static variables. 3) If a function is recursive. 4) If a function return type is other than void, and the return statement doesn’t exist in function body. 5) If a function contains switch or goto statement. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
