larroy commented on issue #14940: Fix warnings URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-521899079 So the request for changes is basically for two additional blank lines (which by the way are allowed by Google style guide and Pep8) this has a CI cost which I don't find justified. I guess I also missed the extra newline when I resolved it. Moving the functions to the CC file reduces binary sizes before linking. Is there anything seriously wrong with this change that requires two vetos? Also fixing warnings and moving some functions from header to implementation is small change enough that can be merged in a single PR in my opinion. We just had a 6k lines PR merged adding numpy operators, I find that there's two different set of criteria applied to some PRs and not others.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
