apeforest commented on a change in pull request #14940: Fix warnings URL: https://github.com/apache/incubator-mxnet/pull/14940#discussion_r314596452
########## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ########## @@ -26,6 +26,7 @@ #if MXNET_USE_MKLDNN == 1 #include "mkldnn_fully_connected-inl.h" +#include <unordered_map> Review comment: @larroy Please don't be so defensive. I simply didn't understand why if a missing header file in the code would cause warning rather than just failing to compile. It would be great if you could answer my question and thanks @ChaiBapchya for pointing me to the location. But again, why it would pass compilation earlier if that needed STL header was missing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
