DickJC123 commented on a change in pull request #15922: Refactor for windows CI
'out of heap space' errors
URL: https://github.com/apache/incubator-mxnet/pull/15922#discussion_r314925116
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1580,6 +1581,20 @@ void PickOpBackward(const nnvm::NodeAttrs& attrs,
});
}
+inline std::string get_reduce_axes_description(const std::string& op_name, int
line) {
Review comment:
The short answer is that the function was formerly in
broadcast_reduce_op_value.cc (with the inline keyword) and I copied it intact
to broadcast_reduce_op.h.
Also, removing `inline` breaks the compile with a 'multiple definitions'
error. One shouldn't put the definition of a stand-alone function in a header
file that's part of multiple translation units without the inline keyword.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
