samskalicky commented on a change in pull request #15886: [WIP] Graph Partition
API
URL: https://github.com/apache/incubator-mxnet/pull/15886#discussion_r314927157
##########
File path: src/c_api/c_api_symbolic.cc
##########
@@ -1181,3 +1182,59 @@ int MXShallowCopySymbol(SymbolHandle src, SymbolHandle*
out) {
*out = out_sym;
API_END_HANDLE_ERROR(delete out_sym);
}
+
+int MXOptimizeForBackend(SymbolHandle sym_handle,
+ const char* backend_name,
+ SymbolHandle* ret_sym_handle,
+ const bool infer_shape_type,
+ const int dev_type,
+ const int dev_id,
+ const mx_uint len,
+ NDArrayHandle* in_args_handle,
+ const mx_uint num_options,
+ const char** keys,
+ const char** vals) {
+ nnvm::Symbol *s = new nnvm::Symbol();
+ API_BEGIN();
+ nnvm::Symbol *sym = static_cast<nnvm::Symbol *>(sym_handle);
+ *s = sym->Copy();
+ nnvm::Graph orig_g = Symbol2Graph(*s);
+ if (infer_shape_type) {
+ Context default_ctx =
Context::Create(static_cast<Context::DeviceType>(dev_type), dev_id);
+ std::map<std::string, Context> ctx_map;
+ NDArray **in_args_ptr = reinterpret_cast<NDArray**>(in_args_handle);
+ mxnet::ShapeVector arg_shapes(len);
+ nnvm::DTypeVector arg_dtypes(len);
+ StorageTypeVector arg_stypes(len);
+ std::vector<Context> in_arg_ctxes(len);
+ std::vector<Context> aux_state_ctxes;
+ for (mx_uint i = 0; i < len; i++) {
+ const auto &in_arg = *(in_args_ptr[i]);
+ arg_shapes.push_back(in_arg.shape());
+ arg_dtypes.push_back(in_arg.dtype());
+ arg_stypes.push_back(in_arg.storage_type());
+ in_arg_ctxes[i] = in_arg.ctx();
+ }
+ orig_g = common::InferForwardAttrs(orig_g, arg_shapes, arg_dtypes,
arg_stypes, default_ctx,
+ ctx_map, in_arg_ctxes, aux_state_ctxes,
true);
+ }
+ std::vector<std::pair<std::string, std::string>> options_map;
+ for (mx_uint i = 0; i < num_options; ++i) {
+ options_map.emplace_back(keys[i], vals[i]);
+ }
+ const auto backend =
mxnet::op::SubgraphBackendRegistry::Get()->GetSubgraphBackend(backend_name);
+ const auto& subgraph_prop_list = backend->GetSubgraphProperties();
+ for (auto property : subgraph_prop_list) {
+ nnvm::Graph g = orig_g;
+ property->SetAttr("graph", g);
Review comment:
dont think we need this if we're going to pass it into the prePartition
function
please check intel's subgraph props to see if they're using the graph
attribute, and if not please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
