larroy commented on a change in pull request #15922: Refactor for windows CI
'out of heap space' errors
URL: https://github.com/apache/incubator-mxnet/pull/15922#discussion_r314929315
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1580,6 +1581,20 @@ void PickOpBackward(const nnvm::NodeAttrs& attrs,
});
}
+inline std::string get_reduce_axes_description(const std::string& op_name, int
line) {
Review comment:
Of course I know that. The question is why isn't declared on the header and
defined in the implementation file as usual. Seems like a big function to
inline. Which adds bloat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
