zoeygxy opened a new pull request #15942: Refines NDArray indexing and adds 
numpy ndarray indexing [DO NOT MERGE YET]
URL: https://github.com/apache/incubator-mxnet/pull/15942
 
 
   ## Description ##
   - Fixed NDArray indexing: newaxis and setitem.
   - Added support for numpy indexing, including basic indexing and advanced 
integer array indexing, None and Ellipsis. 
   <https://docs.scipy.org/doc/numpy/reference/arrays.indexing.html>
   - Added np.full operator interface; test cases not added. 
   - Wrapped slice_assign and slice_assign_scalar method for both numpy.ndarray 
and NDArray, doc added. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Fixed NDArray indexing: newaxis and setitem.
   - [x] Added support for numpy indexing, including basic and advanced 
indexing, None and Ellipsis.
   
   ## Comments ##
   - Need to add test cases for np.full.
   - Boolean Array indexing not supported yet.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to