apeforest commented on a change in pull request #15948: Fix a memory
misalignment in topk operator
URL: https://github.com/apache/incubator-mxnet/pull/15948#discussion_r315824638
##########
File path: 3rdparty/mshadow/mshadow/tensor.h
##########
@@ -69,15 +69,15 @@ struct Shape {
* \param idx dimension index
* \return the corresponding dimension size
*/
- MSHADOW_XINLINE index_t &operator[](index_t idx) {
+ MSHADOW_XINLINE index_t &operator[](int idx) {
Review comment:
This is not directly fixing this bug. However, while checking the tensor
struct, I noticed this data type should be int because it is indexing the
dimension (which is set to int)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services