haojin2 commented on issue #15951: Revert "Numpy-compatible concatenate upstream" URL: https://github.com/apache/incubator-mxnet/pull/15951#issuecomment-523142933 I don't think that's a reasonable assumption. Firstly this PR passed CI several times already (since I rebase with master daily) until some day it gets timeout all the time. I remember for some reason there was a unit test in test_random (probably test_shuffle if I remember correctly) that was taking a very long time so CI was stuck on it. Obviously that was not related with my PR, which was the reason why I'm increasing the CI time limit since I want to unblock several summer interns on their tasks. On the other hand, the only unit test introduced in my PR only takes less than 3 seconds, so I don't think my PR is the cause for CI time regression: ``` nosetests tests/python/unittest/test_numpy_op.py:test_np_concat . ---------------------------------------------------------------------- Ran 1 test in 2.998s OK ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
