larroy commented on a change in pull request #15545: Softmax optimization for
GPU
URL: https://github.com/apache/incubator-mxnet/pull/15545#discussion_r316411854
##########
File path: src/operator/nn/softmax-inl.h
##########
@@ -301,7 +282,7 @@ __global__ void softmax_compute_kernel(DType *in, OType
*out, index_t M, int axi
red::sum::SetInitValue(smem[x]);
Review comment:
let me rephrase. When running Reduce1D, are all the max values reduce into
smem[0] / smax? as I understand the xmxax should be the max of {x_i}. It
actually matters for numerical issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
