anirudhacharya commented on issue #15560: Add fp16 support for topk URL: https://github.com/apache/incubator-mxnet/pull/15560#issuecomment-523673137 > @anirudhacharya: `cuda::less_half<half>()` and `cuda::greater_half<half>()` are not only defined **similarly**, but they are **identica**l and, definitely, it is a bug. yes, sorry for sounding ambiguous. The intent of my previous comment was to ack that it was a bug. > As for the problem with `DeviceRadixSort`, yes, it's not comiled for `mshadow::half::half_t`, but it could be compiled for `__half` and I think we could use that. The solution here would be the usage of separate templates `SortPairsWorkspaseSize`... Thanks for this suggestion, I will try this and see if it works. On the other hand if you have a solution for this already and you would like to make a PR for it, let me know, I can close this and we can merge your code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
