samskalicky commented on a change in pull request #15886: Graph Partition API
URL: https://github.com/apache/incubator-mxnet/pull/15886#discussion_r317222835
##########
File path: src/operator/subgraph/subgraph_property.h
##########
@@ -221,6 +222,12 @@ class SubgraphProperty {
return nullptr;
}
+ virtual void PrePartition(const nnvm::Graph& g,
+ const std::vector<std::pair<std::string, std::string>>& options_map) {}
+
+ virtual void PostPartition(const nnvm::Graph& g,
+ const std::vector<std::pair<std::string, std::string>>& options_map) {}
Review comment:
Dont think we need options_map in the postPartition args list. Any options
that need to be saved can be saved in the SubgraphProperty Class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
