sxjscience commented on a change in pull request #15560: Add fp16 support for
topk
URL: https://github.com/apache/incubator-mxnet/pull/15560#discussion_r317256691
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -4372,6 +4347,45 @@ def get_large_matrix():
expected=[gt_topk(dat=a_npy, axis=1,
ret_typ="indices", k=1,
is_ascend=True)])
+ for dtype in [np.float16, np.float32, np.float64]:
Review comment:
Would you also test for `int32` and `int64`? Also, the testing for `uint8`
and `int8` can be added separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
