apeforest commented on a change in pull request #15943: Added tests to verify Large Vector Support for initial set of ops URL: https://github.com/apache/incubator-mxnet/pull/15943#discussion_r317310275
########## File path: tests/nightly/test_large_vector.py ########## @@ -18,13 +18,15 @@ import numpy as np import mxnet as mx -from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d +from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, default_context, create_vector from mxnet import gluon, nd from tests.python.unittest.common import with_seed # dimension constants LARGE_X = 5000000000 MEDIUM_X = 1000000000 +LARGE_Y = 100000 Review comment: Why do we need a Y dimension for 1D vector test? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
