ChaiBapchya commented on issue #15980: Decouple dtype from shape for Random multinomial URL: https://github.com/apache/incubator-mxnet/pull/15980#issuecomment-524575010 @marcoabreu It doesn't fix a broken nightly test. The issue we encountered while writing nightly test for large vector (2**32) Currently, behavior of random.multinomial is to expect shape and dtype to agree. For eg if dtype is given as float16, shape has to be within max integer limit ``` >>> mx.nd.random.multinomial(mx.nd.random.uniform(shape=65536),dtype="float16") Check failed: ishape[ishape.ndim() - 1] <= mxnet::common::MaxIntegerValue<DType>() (65536 vs. 2048) : 'dtype' does not have a sufficient precision to represent the indices of the input array ``` ``` >>> mx.nd.random.multinomial(mx.nd.random.uniform(shape=4294967296),dtype="float32") Check failed: ishape[ishape.ndim() - 1] <= mxnet::common::MaxIntegerValue<DType>() (4294967296 vs. 16777216) : 'dtype' does not have a sufficient precision to represent the indices of the input array. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
