ZhennanQin commented on a change in pull request #15886: Graph Partition API
URL: https://github.com/apache/incubator-mxnet/pull/15886#discussion_r317853274
##########
File path: src/operator/subgraph/subgraph_property.h
##########
@@ -221,6 +222,11 @@ class SubgraphProperty {
return nullptr;
}
+ virtual void PrePartition(const nnvm::Graph& g,
Review comment:
Got your point. Because in this PR, Prepartition and PostPartition are just
2 empty virtual function, so I can't image the usage of them. Your explanation
makes sense to me. But I still suggest to implement `excluded_ops` to
`default` backend as an example(considering `default` backend is an example, we
can use it to example the features newly added), then other developer can know
how to use this 2 APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
