zoeygxy commented on a change in pull request #15942: Refines NDArray indexing and adds numpy ndarray indexing [READY FOR REVIEW] URL: https://github.com/apache/incubator-mxnet/pull/15942#discussion_r317962419
########## File path: src/operator/tensor/matrix_op-inl.h ########## @@ -973,7 +981,7 @@ inline bool SliceAssignOpShape(const nnvm::NodeAttrs& attrs, CHECK_EQ(in_attrs->size(), 2U); CHECK_EQ(out_attrs->size(), 1U); const mxnet::TShape& dshape = (*in_attrs)[0]; - if (dshape.ndim() == 0U || dshape.Size() == 0U) return false; + if (dshape.ndim() == 0U) return false; Review comment: Fixed. Thx! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
