zhreshold commented on a change in pull request #15947: [WIP] add dataset
filter API
URL: https://github.com/apache/incubator-mxnet/pull/15947#discussion_r318241075
##########
File path: python/mxnet/gluon/data/dataset.py
##########
@@ -40,6 +40,9 @@ def __getitem__(self, idx):
def __len__(self):
raise NotImplementedError
+ def filter(self, filter_fn):
Review comment:
many datasets are not derived from SimpleDataset but `Dataset` itself. Any
plan for supporting filter in this base class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
