yuxihu commented on issue #16013: Windows cmake flags cleanup URL: https://github.com/apache/incubator-mxnet/pull/16013#issuecomment-525928813 The changes look straightforward. Two questisons: 1. ON/OFF is the preferred/recommended way of setting cmake flags? 0/1 also worked, right? 2. Why removing USE_PROFILER? Is it ON in other platforms? I think we have profiler related tests. Would it be affected?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
