mseth10 commented on a change in pull request #15886: Graph Partition API
URL: https://github.com/apache/incubator-mxnet/pull/15886#discussion_r319333297
##########
File path: python/mxnet/symbol/symbol.py
##########
@@ -1437,6 +1437,54 @@ def _gen_atomic_symbol(self):
return Symbol(handle)
+ def optimize_for(self, backend, args=None, **kwargs):
Review comment:
I agree with you on having support for passing shape/type/stype dicts just
like simple_bind. I will add that support in a later PR. Since we accept kwargs
now, it would not be a breaking API change.
I understand your concern about having a more explicit api, but I prefer
keeping it this way for the following reason. Users are expected to know what
arguments are required by the backend. The backend errors out if the required
arguments are not provided whether or not we have an explicit flag. At this
point, it's not a choice for users to not infer shape/type/stype when the
backend requires it, or vice versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
