sxjscience commented on issue #11795: Fix problematic backward of take & embedding URL: https://github.com/apache/incubator-mxnet/pull/11795#issuecomment-526641269 I’ll do that later if you do not have time. Currently, there are lots of other urgent issues for me so I’m asking for help. Thanks, Xingjian Get Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: Xingjian SHI Sent: Friday, August 30, 2019 7:43:41 AM To: apache/incubator-mxnet <[email protected]>; apache/incubator-mxnet <[email protected]> Cc: Comment <[email protected]> Subject: Re: [apache/incubator-mxnet] Fix problematic backward of take & embedding (#11795) Would you help profile the change? I think the current change should not have passed the code interview. Get Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: Kellen Sunderland <[email protected]> Sent: Friday, August 30, 2019 5:42:43 AM To: apache/incubator-mxnet <[email protected]> Cc: Xingjian SHI <[email protected]>; Comment <[email protected]> Subject: Re: [apache/incubator-mxnet] Fix problematic backward of take & embedding (#11795) Could be a valid point Xingjian. Are you seeing differences when measured with nvprof? Can you post a summary? On Mon, Aug 26, 2019, 8:45 AM Xingjian Shi <[email protected]> wrote: > I find the previous performance test was conducted using time.time(). It’s > not safe to do that due to the tremendous overhead of the imperative API in > MXNet. We should rely on nvprof in the future. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABYZGE5LIWKYDBHYIQHFJE3QGP3BDA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYSTQ#issuecomment-524912974>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABYZGEYRTSCQE3Q55QNSOH3QGP3BDANCNFSM4FKPUUDA> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABHQH3TLFEDO3Z6PGSEBIXTQHEIUHA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RRHLY#issuecomment-526586799>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABHQH3RIP6DA7SN26CH5JI3QHEIUHANCNFSM4FKPUUDA>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
