zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r321386949
########## File path: tests/python/unittest/test_optimizer.py ########## @@ -396,6 +397,7 @@ def update(self, index, weight, grad, state): weight32[:] += -lr * (grad32 + wd * weight32) else: weight32[:] += (self.momentum**2 * mom) - lr*(self.momentum+1)*(grad32 + wd*weight32) + mom = (self.momentum*mom) - lr*(grad32 + wd*weight32) Review comment: Thanks! You are right. The MXNet implementation is puting lr inside. The update should be: ![image](https://user-images.githubusercontent.com/8041160/64364156-2c4a0200-cfc7-11e9-92d6-331d8b656d73.png) ![image](https://user-images.githubusercontent.com/8041160/64364165-2f44f280-cfc7-11e9-9416-b092fd294294.png) I will check your implementation again. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services