larroy commented on a change in pull request #15808: Add option to choose
between OMP implementations
URL: https://github.com/apache/incubator-mxnet/pull/15808#discussion_r321990215
##########
File path: CMakeLists.txt
##########
@@ -452,14 +451,18 @@ if(USE_OPENMP)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
add_definitions(-DMXNET_USE_OPENMP=1)
- else()
+ elseif(USE_OPENMP STREQUAL "PLATFORM" OR USE_OPENMP STREQUAL "ON")
Review comment:
They are the same, for backwards compatibility, meaning if someone had
USE_OPENMP=ON will continue working with the OMP implementation which has been
shown to be most stable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
