larroy commented on a change in pull request #14535: [DOC] Updated install 
instructions for mac
URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321990795
 
 

 ##########
 File path: docs/install/osx_setup.md
 ##########
 @@ -97,17 +101,23 @@ Install the dependencies, required for MXNet, with the 
following commands:
 ### Build MXNet Shared Library
 After you have installed the dependencies, pull the MXNet source code from Git 
and build MXNet to produce an MXNet library called ```libmxnet.so```. You can 
clone the repository as described in the following code block, or you may try 
the [download links](download.md) for your desired MXNet version.
 
-The file called ```osx.mk``` has the configuration required for building MXNet 
on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by 
the ```make``` command:
-
 ```bash
-    git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet
-    cd ~/mxnet
-    cp make/osx.mk ./config.mk
-    echo "USE_BLAS = openblas" >> ./config.mk
-    echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk
-    echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk
-    echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk
-    make -j$(sysctl -n hw.ncpu)
+git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet
+cd ~/mxnet && pushd .
+mkdir -p build && cd build
+cmake \
+    -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
+    -DCMAKE_C_COMPILER_LAUNCHER=ccache \
+    -DUSE_MKL_IF_AVAILABLE=OFF \
+    -DUSE_MKLDNN=ON \
+    -DUSE_CUDA=OFF \
+    -DUSE_OPENMP=OFF \
+    -DUSE_OPENCV=ON \
+    -DUSE_SIGNAL_HANDLER=ON \
+    -DCMAKE_BUILD_TYPE=Debug \
+    -GNinja ..
+ninja
+popd
 
 Review comment:
   Isn't it obvious? to return back to the root directory. Common practice in 
shell scripts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to