sxjscience commented on a change in pull request #16016: [numpy] operator 
ravel, derive from reshape
URL: https://github.com/apache/incubator-mxnet/pull/16016#discussion_r323510881
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/_op.py
 ##########
 @@ -2363,3 +2363,55 @@ def var(a, axis=None, dtype=None, out=None, ddof=0, 
keepdims=False):  # pylint:
     0.2025
     """
     return _npi.var(a, axis=axis, dtype=dtype, ddof=ddof, keepdims=keepdims, 
out=out)
+
+
+@set_module('mxnet.ndarray.numpy')
+def ravel(x, out=None):
 
 Review comment:
   In numpy, we have the `order='C'` argument. We need to add that and raise 
NotImplementedError if the value is other than `C`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to