haojin2 commented on a change in pull request #15819: [Numpy]flip
URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r323630349
##########
File path: src/operator/numpy/np_matrix_op-inl.h
##########
@@ -60,6 +60,81 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs,
}
}
+struct FlipParam : public dmlc::Parameter<FlipParam> {
+ mxnet::Tuple<int> axis;
+ DMLC_DECLARE_PARAMETER(FlipParam) {
+ DMLC_DECLARE_FIELD(axis)
+ .describe("The axis which to flip elements.");
+ }
+};
+
+struct flip0dim_shared_kernel {
+ template<typename DType>
+ MSHADOW_XINLINE static void Map(int i,
+ DType* out_data,
+ const DType* in_data) {
+ out_data[i] = in_data[i];
+ }
+};
+
+#define FLIP_MAX_DIM 10
+#define FLIP_MIN_DIM -1
+
+template<typename xpu>
+void NumpyFlipForwardImpl(const OpContext& ctx,
+ const std::vector<TBlob>& inputs,
+ const std::vector<TBlob>& outputs,
+ const std::vector<index_t>& stride_,
+ const std::vector<index_t>& trailing_,
+ const index_t& flip_index);
+
+template<typename xpu>
+void NumpyFlipForward(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<TBlob>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<TBlob>& outputs) {
+ const FlipParam& param = nnvm::get<FlipParam>(attrs.parsed);
+ mxnet::Tuple<int> axistemp;
+ CHECK_EQ(inputs[0].type_flag_, outputs[0].type_flag_);
+ CHECK_LT(param.axis.ndim(), FLIP_MAX_DIM);
+ CHECK_GE(param.axis.ndim(), FLIP_MIN_DIM);
+ if (param.axis.ndim() == FLIP_MIN_DIM) {
+ if (inputs[0].shape_.ndim() == 0) {
+ mshadow::Stream<xpu> *s = ctx.get_stream<xpu>();
+ MSHADOW_TYPE_SWITCH(outputs[0].type_flag_, DType, {
+ mxnet_op::Kernel<flip0dim_shared_kernel, xpu>::Launch(s,
inputs[0].Size(),
Review comment:
Please directly call `copy` function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
