Laurawly commented on a change in pull request #15816: Numpy Tril (Lower
triangle) operator
URL: https://github.com/apache/incubator-mxnet/pull/15816#discussion_r323902000
##########
File path: tests/python/unittest/test_numpy_op.py
##########
@@ -92,6 +92,65 @@ def is_int(dtype):
assert_almost_equal(mx_out.asnumpy(), np_out,
rtol=1e-3, atol=1e-5)
+@with_seed()
+@use_np
+def test_np_tril():
+ config = [
+ ((4, 2), 3),
+ ((4, 2), 9),
+ ((4, 2), 0),
+ ((4, 2), 2),
+ ((4, 5, 6), 0),
+ ((4, 5, 6), 5),
+ ((4, 5, 6), 2),
+ ((4, 5, 6), 20),
+ ((7, 8, 10, 9), 0),
+ ((7, 8, 10, 9), 5),
+ ((7, 8, 10, 9), 9),
+ ((7, 8, 10, 9), 13),
+ ((4, 0), 0),
+ ((4, 0), 2),
+ ((4, 0), 4),
+ ((4, 0), 7),
+ ((3, ), 0),
+ ((3, ), 2),
+ ((3, ), 5)
Review comment:
Can we add test cases when k < 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
