wkcn commented on a change in pull request #16175: [Dataset] add shard API
URL: https://github.com/apache/incubator-mxnet/pull/16175#discussion_r324503936
##########
File path: python/mxnet/gluon/data/dataset.py
##########
@@ -84,14 +84,13 @@ def shard(self, num_shards, index):
"""
assert index < num_shards, 'Shard index of out bound: %d out of
%d'%(index, num_shards)
assert num_shards > 0, 'Number of shards must be greater than 0'
+ assert index >= 0, 'Index must be non-negative'
length = len(self)
- shard_len = length // num_shards
+ shard_len = (length + num_shards - 1) // num_shards
# Compute the start index for this partition
start = shard_len * index
# Compute the end index for this partition
- end = start + shard_len
- if index == num_shards - 1:
- end = length
+ end = start + shard_len if index < num_shards - 1 else length
Review comment:
When `length=6, num_shareds=4`,
`shared_len = (6 + 4 - 1) // 4 = 2`
The interval of the four partitions are `[0, 2), [2, 4), [4, 6), [6, 6)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
