perdasilva opened a new pull request #16202: [CD] Add COMMIT_ID param to release job URL: https://github.com/apache/incubator-mxnet/pull/16202 ## Description ## Currently, if a new commit on master comes between the different stages, the CD pipeline will break. The reason is, the libxmet binary will be posted against one commit id, but the release pipeline (e.g. for PyPI packages), will be kicked off with the latest commit id. This PR proposes to fix this issue by introducing a COMMIT_ID parameter to the release job definition. This solves the issue. This means we can use the commit id as the branch specifier in the 'Pipeline' section of the job configuration and ensure that the specified commit_id will be used for the build. This comes with some drawbacks, namely that release job will assume the state of the last job it ran. This can change the pipeline definition and lead to hard to track errors. <img width="1287" alt="Screen Shot 2019-09-18 at 8 05 47 PM" src="https://user-images.githubusercontent.com/785683/65173796-e291fa80-da4f-11e9-8b1f-aeb9d0781f26.png";> ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
![https://user-images.githubusercontent.com/785683/65173796-e291fa80-da4f-11e9-8b1f-aeb9d0781f26.png"](https://user-images.githubusercontent.com/785683/65173796-e291fa80-da4f-11e9-8b1f-aeb9d0781f26.png"){kind=link}