ElaineBao commented on a change in pull request #16199: [mkldnn-v1.0] Add
MKL-DNN BN
URL: https://github.com/apache/incubator-mxnet/pull/16199#discussion_r325965175
##########
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##########
@@ -185,21 +119,20 @@ class MKLDNNBNForward {
template<typename DType>
static MKLDNNBNForward &GetBNForward(const BatchNormParam& param,
const OpContext &ctx, const
mkldnn::memory *data_mem,
- unsigned flags) {
+ mkldnn::normalization_flags flags) {
#if DMLC_CXX11_THREAD_LOCAL
static thread_local std::unordered_map<MKLDNNBNSignature, MKLDNNBNForward,
OpHash> fwds;
#else
static MX_THREAD_LOCAL std::unordered_map<MKLDNNBNSignature,
MKLDNNBNForward, OpHash> fwds;
#endif
MKLDNNBNSignature key(param);
key.AddSign(ctx.is_train);
- key.AddSign(param.use_global_stats);
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
