ElaineBao commented on a change in pull request #16259: [mkldnn-v1.0] Add
MKL-DNN deconv
URL: https://github.com/apache/incubator-mxnet/pull/16259#discussion_r328400676
##########
File path: src/operator/nn/deconvolution.cc
##########
@@ -27,14 +27,75 @@
#include "./deconvolution-inl.h"
#include "../operator_common.h"
#include "../../common/utils.h"
-#if MXNET_USE_MKLDNN == 1
-#include "./mkldnn/mkldnn_ops-inl.h"
+#if MXNET_USE_MKLDNN == 100
#include "./mkldnn/mkldnn_base-inl.h"
-#endif
+#include "./mkldnn/mkldnn_ops-inl.h"
+#endif // MXNET_USE_MKLDNN
namespace mxnet {
namespace op {
+#if MXNET_USE_MKLDNN == 100
+static void DeconvolutionComputeExCPU(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<NDArray>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<NDArray>& outputs) {
+ const DeconvolutionParam& params =
nnvm::get<DeconvolutionParam>(attrs.parsed);
+ if (SupportMKLDNNDeconv(params, inputs[0])) {
+ MKLDNN_OPCHECK_INIT(false, outputs.size(), inputs, outputs);
Review comment:
why false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
