reminisce commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536249177
 
 
   @marcoabreu There are two problems reflected here. IMHO, we should not 
tangle them.
   
   1. The `Release` build type is not set as the default value for cmake build 
config. Considering most of the users would just adopt the default settings we 
provide, this problem should have been corrected to make the performance of the 
binaries produced by make and cmake comparable. This PR is submitted to address 
this problem.
   
   2. The lib built using either current `cmake` (without `Release` build type) 
or `make` with `DEBUG=1` would fail on reduce-like operators on GPUs, `sum` for 
example. This problem has been observed many times by various users. That part 
of code was owned by Nvidia folks. The algorithm itself is so sophisticated 
that it requires their expertise to dive in. We should track this issue in 
another thread, instead of requesting the contributors fixing the build type 
problem to look into the problem that is out of their domain knowledge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to