zachgk commented on issue #14583: Install page history broken URL: https://github.com/apache/incubator-mxnet/issues/14583#issuecomment-536697442 @aaronmarkham This issue is still there. To reproduce, 1. go to the installation docs on the get_started page. 2. Randomly click on any of the buttons. Note that it changes the url path to index.html which is also wrong. 3. If you press the browser back button, it doesn't do anything. If you press it repeatedly, it only takes effect if you press it more than the number of times you changed the installation options. You can see the relevant code [here](https://github.com/apache/incubator-mxnet/blob/master/docs/static_site/src/assets/js/options.js). There are two ways to resolve this problem: 1. We simply don't use the [history api](https://developer.mozilla.org/en-US/docs/Web/API/History_API) and delete all occurrences of history.pushState. Then, the back button will simply leave the get_started page. 2. We handle the history `popstate` event so that presses to the back (and I believe forward) button are handled and will switch to the previously selected options. There may be other things to fix to get this working as well (especially due to the new site).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
