apeforest commented on a change in pull request #16371: Adding large tensor
support and test for gather_nd
URL: https://github.com/apache/incubator-mxnet/pull/16371#discussion_r331716770
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -1048,7 +1048,10 @@ def _advanced_index_to_array(idx, ax_len, ctx):
The ``ax_len`` is used to convert `slice` objects to integer arrays.
"""
- idx_dtype = 'int32'
+ if sys.version_info[0] > 2 and _int64_enabled():
+ idx_dtype = 'int64'
+ else:
+ idx_dtype = 'int32'
Review comment:
Have we measured runtime difference by adding this check in ndarray.py? Can
we some simple test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
