larroy commented on a change in pull request #15940: Add boolean ndarray
URL: https://github.com/apache/incubator-mxnet/pull/15940#discussion_r331727745
##########
File path: tests/python/unittest/test_numpy_op.py
##########
@@ -240,27 +236,38 @@ def is_int(dtype):
in_data_dim = random.choice([2, 3, 4])
shape = rand_shape_nd(in_data_dim, dim=3)
acc_type = {'float16': 'float32', 'float32': 'float64', 'float64':
'float64',
- 'int8': 'int32', 'int32': 'int64', 'int64': 'int64'}
+ 'int8': 'int32', 'int32': 'int64', 'int64': 'int64', 'bool':
'int64'}
for hybridize in [False, True]:
Review comment:
would using
https://docs.python.org/3.7/library/itertools.html#itertools.product help
readability of the code and make it less nested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
