[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #16272: [mkldnn-v1.0] Add MKL-DNN Pooling

Sun, 06 Oct 2019 08:46:12 -0700 

TaoLv commented on a change in pull request #16272: [mkldnn-v1.0] Add MKL-DNN 
Pooling
URL: https://github.com/apache/incubator-mxnet/pull/16272#discussion_r331796042
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling.cc
 ##########
 @@ -401,14 +363,21 @@ void MKLDNNPoolingGradCompute(const OpContext &ctx, 
const PoolingParam &param,
 
   auto &bwd = GetPoolingBwd(param, in_data, in_grad, out_grad);
   auto diff_src_mem =
-      CreateMKLDNNMem(in_grad, bwd.pd.diff_src_primitive_desc(), req);
+      CreateMKLDNNMem(in_grad, bwd.pd.diff_src_desc(), req);
+
+  mkldnn_args_map_t args = {
+    {MKLDNN_ARG_DIFF_DST, *(out_grad.GetMKLDNNData())},
+    {MKLDNN_ARG_DIFF_SRC, *diff_src_mem.second },
+  };
+  if (workspace != nullptr) {
 
 Review comment:
   Also check `with_workspace`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to