wes3 commented on issue #351: Bt5 extended advertising - host part URL: https://github.com/apache/incubator-mynewt-core/pull/351#issuecomment-311433916 I am not sure I have a strong opinion on the BLE_LL_CFG_FEAT_LL_EXT_ADV and BLE_EXT_ADV. I see why we want to keep BLE_LL_CFG_FEAT_LL_EXT_ADV; that makes sense. What I think we should do is restrict LL_EXT_ADV so that it basically mirrors BLE_EXT_ADV. Chris says you can do this: BLE_LL_CFG_FEAT_LL_EXT_ADV: description: > This option is used to enable/disable support for Extended Advertising Feature. That means extended scanner, advertiser and connect. value: 0 restrictions: - 'BLE_EXT_ADV if 1' - '!BLE_EXT_ADV if 0' BTW: I reviewed some of the other code and it all looks good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
