ccollins476ad commented on a change in pull request #351: Bt5 extended
advertising - host part
URL:
https://github.com/apache/incubator-mynewt-core/pull/351#discussion_r124591814
##########
File path: net/nimble/host/src/ble_gap.c
##########
@@ -2154,6 +2155,66 @@ ble_gap_disc_tx_params(uint8_t own_addr_type,
return 0;
}
+#if MYNEWT_VAL(BLE_EXT_ADV)
+static int
+ble_gap_ext_disc_tx_params(uint8_t own_addr_type, uint8_t filter_policy,
+ const struct ble_hs_hci_ext_scan_param *uncoded_params,
+ const struct ble_hs_hci_ext_scan_param *coded_params)
+{
+ uint8_t buf[BLE_HCI_CMD_HDR_LEN + BLE_HCI_LE_EXT_SCAN_BASE_LEN +
+ 2 * BLE_HCI_LE_EXT_SCAN_SINGLE_PARAM_LEN];
+ uint8_t phy_mask = 0;
+ struct ble_hs_hci_ext_scan_param param[2] = {0};
Review comment:
You're right - `{0}` is valid and should be accepted by the compiler. It
appears older versions of gcc complain about this case. Unfortunately, the
arm-gcc-none-eabi gcc that we recommend for macOS (4.9.3) reports a warning
here. I think we need to use a syntax which works for this version of gcc as
well as newer ones. I believe `{{0}}` will do the trick.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
