ccollins476ad commented on a change in pull request #72: MYNEWT-553; add option to print only executed commands during build URL: https://github.com/apache/incubator-mynewt-newt/pull/72#discussion_r124843017
########## File path: newt/vendor/mynewt.apache.org/newt/util/util.go ########## @@ -42,6 +42,7 @@ import ( ) var Verbosity int +var PrintBuildCmds bool Review comment: Cool, looks good. What do you think about renaming `PrintBuildCmds` to `PrintShellCmds` (or similar)? Other tools use the util library, but they don't build anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
